Fix image block schema #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davisagli
reviewed
Dec 9, 2024
| @@ -0,0 +1 @@ | |||
| Fix Image block schema @danalvrz | |||
There was a problem hiding this comment.
@danalvrz Can you be more specific? This PR is hard to review because I don't know what you're trying to fix.
There was a problem hiding this comment.
@davisagli I just updated it, thanks! With the new widget and image options on VLT 6 there was an issue with undefined properties when nesting an Image in a Grid block. With this change we enhance the Image schema more accurately based on its context.
davisagli
reviewed
Dec 9, 2024
There was a problem hiding this comment.
@sneridagh Seems to work ok in my testing. Could you have a look as well?
davisagli
approved these changes
Dec 9, 2024
Co-authored-by: David Glick <[email protected]>
sneridagh
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.